fix: improve OIDC account linking UI #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4036 +/- ##
==========================================
+ Coverage 78.39% 78.41% +0.02%
==========================================
Files 370 370
Lines 26127 26155 +28
==========================================
+ Hits 20481 20509 +28
Misses 4088 4088
Partials 1558 1558 ☔ View full report in Codecov by Sentry. |
hperl
requested changes
Aug 21, 2024
jonas-jonas
changed the title
aeneasr
reviewed
Aug 23, 2024
aeneasr
approved these changes
Aug 27, 2024
|
Needs a merge, then good to go! |
…untLinkingMessages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the account linking UI, to only show relevant options to the user. E.g. if the user previously registered using a password, but tries to log into the account using Google, we only show the password input. Similarly, if they used Apple the first time, and Google on the next login, they would only see the Apple login button. If they have both a password and Apple set up, Ory Kratos will show both as options.
Related issue(s)
Fixes #5983
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments